Update deployment.yaml - fix container #378
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gandazgul Image is available for testing. |
MuneebAijaz
requested changes
Sep 14, 2023
| @@ -31,25 +31,21 @@ spec: | |||
| {{- toYaml . | nindent 8 }} | |||
| {{- end }} | |||
| containers: | |||
| - securityContext: {{- toYaml .Values.forecastle.container.securityContext | nindent 12 }} | |||
| - name: {{ template "forecastle.name" . }} | |||
| securityContext: {{- toYaml .Values.forecastle.container.securityContext | nindent 12 }} | |||
There was a problem hiding this comment.
Suggested change
| securityContext: {{- toYaml .Values.forecastle.container.securityContext | nindent 12 }} | |
| securityContext: {{- toYaml .Values.forecastle.container.securityContext | nindent 10 }} |
| @@ -77,6 +73,10 @@ spec: | |||
| {{ toYaml .Values.forecastle.openshiftOauthProxy.resources | indent 10 }} | |||
| {{- end }} | |||
| {{- end }} | |||
| {{- if .Values.forecastle.deployment.securityContext }} | |||
| securityContext: | |||
| {{- toYaml . | nindent 10 }} | |||
There was a problem hiding this comment.
Suggested change
| {{- toYaml . | nindent 10 }} | |
| {{- toYaml .Values.forecastle.deployment.securityContext | nindent 8 }} |
|
hi @gandazgul ive requested some changes, i fear the mistake comes from the old versions of the chart. Please do run helm template to be sure about indentation and templating. thanks |
|
PR is stale. Closing it. |
|
Sorry I completely lost track of this I've been using my branch which just works and forgot to check back here. Is the main chart now fixed? At the time this seemed critical the chart was not working at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.